Re: [PATCH v2 2/2] nbd/server: Use drained block ops to quiesce the server

2021-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2021 15:44, Sergio Lopez wrote: On Wed, Jun 02, 2021 at 03:06:02PM +0300, Vladimir Sementsov-Ogievskiy wrote: 02.06.2021 09:05, Sergio Lopez wrote: Before switching between AioContexts we need to make sure that we're fully quiesced ("nb_requests == 0" for every client) when entering the d

Re: [PATCH v2 2/2] nbd/server: Use drained block ops to quiesce the server

2021-06-02 Thread Sergio Lopez
On Wed, Jun 02, 2021 at 03:06:02PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 02.06.2021 09:05, Sergio Lopez wrote: > > Before switching between AioContexts we need to make sure that we're > > fully quiesced ("nb_requests == 0" for every client) when entering the > > drained section. > > > > To

Re: [PATCH v2 2/2] nbd/server: Use drained block ops to quiesce the server

2021-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2021 09:05, Sergio Lopez wrote: Before switching between AioContexts we need to make sure that we're fully quiesced ("nb_requests == 0" for every client) when entering the drained section. To do this, we set "quiescing = true" for every client on ".drained_begin" to prevent new coroutines

[PATCH v2 2/2] nbd/server: Use drained block ops to quiesce the server

2021-06-01 Thread Sergio Lopez
Before switching between AioContexts we need to make sure that we're fully quiesced ("nb_requests == 0" for every client) when entering the drained section. To do this, we set "quiescing = true" for every client on ".drained_begin" to prevent new coroutines from being created, and check if "nb_req