Re: [PATCH v2 3/4] block: move block exports to libblockdev

2020-09-30 Thread Stefan Hajnoczi
On Tue, Sep 29, 2020 at 12:36:10PM -0500, Eric Blake wrote: > On 9/29/20 7:55 AM, Stefan Hajnoczi wrote: > > Block exports are used by softmmu, qemu-storage-daemon, and qemu-nbd. > > They are not used by other programs and are not otherwise needed in > > libblock. > > > > Undo the recent move of b

Re: [PATCH v2 3/4] block: move block exports to libblockdev

2020-09-29 Thread Eric Blake
On 9/29/20 7:55 AM, Stefan Hajnoczi wrote: > Block exports are used by softmmu, qemu-storage-daemon, and qemu-nbd. > They are not used by other programs and are not otherwise needed in > libblock. > > Undo the recent move of blockdev-nbd.c from blockdev_ss into block_ss. > Since bdrv_close_all() (

Re: [PATCH v2 3/4] block: move block exports to libblockdev

2020-09-29 Thread Eric Blake
On 9/29/20 7:55 AM, Stefan Hajnoczi wrote: Block exports are used by softmmu, qemu-storage-daemon, and qemu-nbd. They are not used by other programs and are not otherwise needed in libblock. Undo the recent move of blockdev-nbd.c from blockdev_ss into block_ss. Since bdrv_close_all() (libblock)

Re: [PATCH v2 3/4] block: move block exports to libblockdev

2020-09-29 Thread Paolo Bonzini
On 29/09/20 14:55, Stefan Hajnoczi wrote: > Block exports are used by softmmu, qemu-storage-daemon, and qemu-nbd. > They are not used by other programs and are not otherwise needed in > libblock. > > Undo the recent move of blockdev-nbd.c from blockdev_ss into block_ss. > Since bdrv_close_all() (l

[PATCH v2 3/4] block: move block exports to libblockdev

2020-09-29 Thread Stefan Hajnoczi
Block exports are used by softmmu, qemu-storage-daemon, and qemu-nbd. They are not used by other programs and are not otherwise needed in libblock. Undo the recent move of blockdev-nbd.c from blockdev_ss into block_ss. Since bdrv_close_all() (libblock) calls blk_exp_close_all() (libblockdev) a stu