Re: [PATCH v2 6/8] block: do not acquire AioContext in check_to_replace_node

2021-05-05 Thread Paolo Bonzini
On 19/04/21 10:55, Emanuele Giuseppe Esposito wrote: + * + * Called with AioContext lock held. ... for @to_replace_bs. aio_context_acquire(replace_aio_context); +if (!check_to_replace_node(bs, to_replace_bs, replaces, errp)) { A release is missing here. Paolo +

[PATCH v2 6/8] block: do not acquire AioContext in check_to_replace_node

2021-04-19 Thread Emanuele Giuseppe Esposito
Make the (only) caller do it. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Signed-off-by: Emanuele Giuseppe Esposito --- block.c | 22 +- blockdev.c| 7 ++- include/block/block.h | 1 + 3 files changed, 12 insertions(+), 18