Re: [PATCH v3 01/14] hw/char/serial-pci: Replace DO_UPCAST(PCISerialState) by PCI_SERIAL()

2023-02-16 Thread Philippe Mathieu-Daudé
On 16/2/23 15:17, BALATON Zoltan wrote: On Thu, 16 Feb 2023, Philippe Mathieu-Daudé wrote: On 16/2/23 12:20, Thomas Huth wrote: On 13/02/2023 19.43, Philippe Mathieu-Daudé wrote: Use the PCI_SERIAL() QOM type-checking macro to avoid DO_UPCAST(). Signed-off-by: Philippe Mathieu-Daudé ---   hw

Re: [PATCH v3 01/14] hw/char/serial-pci: Replace DO_UPCAST(PCISerialState) by PCI_SERIAL()

2023-02-16 Thread BALATON Zoltan
On Thu, 16 Feb 2023, Philippe Mathieu-Daudé wrote: On 16/2/23 12:20, Thomas Huth wrote: On 13/02/2023 19.43, Philippe Mathieu-Daudé wrote: Use the PCI_SERIAL() QOM type-checking macro to avoid DO_UPCAST(). Signed-off-by: Philippe Mathieu-Daudé ---   hw/char/serial-pci.c | 7 +--   1 file c

Re: [PATCH v3 01/14] hw/char/serial-pci: Replace DO_UPCAST(PCISerialState) by PCI_SERIAL()

2023-02-16 Thread Philippe Mathieu-Daudé
On 16/2/23 12:20, Thomas Huth wrote: On 13/02/2023 19.43, Philippe Mathieu-Daudé wrote: Use the PCI_SERIAL() QOM type-checking macro to avoid DO_UPCAST(). Signed-off-by: Philippe Mathieu-Daudé ---   hw/char/serial-pci.c | 7 +--   1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v3 01/14] hw/char/serial-pci: Replace DO_UPCAST(PCISerialState) by PCI_SERIAL()

2023-02-16 Thread Thomas Huth
On 13/02/2023 19.43, Philippe Mathieu-Daudé wrote: Use the PCI_SERIAL() QOM type-checking macro to avoid DO_UPCAST(). Signed-off-by: Philippe Mathieu-Daudé --- hw/char/serial-pci.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/char/serial-pci.c b/hw/char/seria

[PATCH v3 01/14] hw/char/serial-pci: Replace DO_UPCAST(PCISerialState) by PCI_SERIAL()

2023-02-13 Thread Philippe Mathieu-Daudé
Use the PCI_SERIAL() QOM type-checking macro to avoid DO_UPCAST(). Signed-off-by: Philippe Mathieu-Daudé --- hw/char/serial-pci.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c index 801b769aba..9689645cac 100644 --- a/hw/ch