Re: [PATCH v3 01/18] hw/block/nvme: bump spec data structures to v1.3

2020-07-08 Thread Klaus Jensen
g...@samsung.com; kw...@redhat.com; mre...@redhat.com; > > mlevi...@redhat.com; phi...@redhat.com; kbu...@kernel.org; > > k.jen...@samsung.com > > Subject: Re: [PATCH v3 01/18] hw/block/nvme: bump spec data structures to > > v1.3 > > > > On Jul 8 19:19, Dmitry Fomichev wr

RE: [PATCH v3 01/18] hw/block/nvme: bump spec data structures to v1.3

2020-07-08 Thread Dmitry Fomichev
hi...@redhat.com; kbu...@kernel.org; > k.jen...@samsung.com > Subject: Re: [PATCH v3 01/18] hw/block/nvme: bump spec data structures to > v1.3 > > On Jul 8 19:19, Dmitry Fomichev wrote: > > Looks good with a small nit (see below), > > > > Reviewed-by: Dmitry Fomichev

Re: [PATCH v3 01/18] hw/block/nvme: bump spec data structures to v1.3

2020-07-08 Thread Klaus Jensen
On Jul 8 19:19, Dmitry Fomichev wrote: > Looks good with a small nit (see below), > > Reviewed-by: Dmitry Fomichev > > > > On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote: > > +#define NVME_TEMP_TMPTH(temp) ((temp >> 0) & 0x) > > There is an extra space after temp >> > Good catch

Re: [PATCH v3 01/18] hw/block/nvme: bump spec data structures to v1.3

2020-07-08 Thread Dmitry Fomichev
Looks good with a small nit (see below), Reviewed-by: Dmitry Fomichev > On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Add missing fields in the Identify Controller and Identify Namespace > data structures to bring them in line with NVMe v1.3. > > This also a

[PATCH v3 01/18] hw/block/nvme: bump spec data structures to v1.3

2020-07-05 Thread Klaus Jensen
From: Klaus Jensen Add missing fields in the Identify Controller and Identify Namespace data structures to bring them in line with NVMe v1.3. This also adds data structures and defines for SGL support which requires a couple of trivial changes to the nvme block driver as well. Signed-off-by: Kl