Re: [PATCH v3 02/12] block/io.c: drop assertion on double waiting for request serialisation

2020-08-19 Thread Paolo Bonzini
On 19/08/20 17:28, Stefan Hajnoczi wrote: > On Mon, Aug 17, 2020 at 12:15:43PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> The comments states, that on misaligned request we should have already >> been waiting. But for bdrv_padding_rmw_read, we called >> bdrv_mark_request_serialising with align =

Re: [PATCH v3 02/12] block/io.c: drop assertion on double waiting for request serialisation

2020-08-19 Thread Stefan Hajnoczi
On Mon, Aug 17, 2020 at 12:15:43PM +0300, Vladimir Sementsov-Ogievskiy wrote: > The comments states, that on misaligned request we should have already > been waiting. But for bdrv_padding_rmw_read, we called > bdrv_mark_request_serialising with align = request_alignment, and now > we serialise with

[PATCH v3 02/12] block/io.c: drop assertion on double waiting for request serialisation

2020-08-17 Thread Vladimir Sementsov-Ogievskiy
The comments states, that on misaligned request we should have already been waiting. But for bdrv_padding_rmw_read, we called bdrv_mark_request_serialising with align = request_alignment, and now we serialise with align = cluster_size. So we may have to wait again with larger alignment. Note, that