Re: [PATCH v3 02/25] include/block/block: split header into I/O and global state API

2021-10-21 Thread Stefan Hajnoczi
On Tue, Oct 12, 2021 at 04:48:43AM -0400, Emanuele Giuseppe Esposito wrote: > block.h currently contains a mix of functions: > some of them run under the BQL and modify the block layer graph, > others are instead thread-safe and perform I/O in iothreads. > It is not easy to understand which

Re: [PATCH v3 02/25] include/block/block: split header into I/O and global state API

2021-10-15 Thread Emanuele Giuseppe Esposito
diff --git a/include/block/block-common.h b/include/block/block-common.h new file mode 100644 index 00..4f1fd8de21 --- /dev/null +++ b/include/block/block-common.h @@ -0,0 +1,389 @@ +#ifndef BLOCK_COMMON_H +#define BLOCK_COMMON_H As a new file, it probably deserves a copyright/license

Re: [PATCH v3 02/25] include/block/block: split header into I/O and global state API

2021-10-14 Thread Eric Blake
On Tue, Oct 12, 2021 at 04:48:43AM -0400, Emanuele Giuseppe Esposito wrote: > block.h currently contains a mix of functions: > some of them run under the BQL and modify the block layer graph, > others are instead thread-safe and perform I/O in iothreads. > It is not easy to understand which

[PATCH v3 02/25] include/block/block: split header into I/O and global state API

2021-10-12 Thread Emanuele Giuseppe Esposito
block.h currently contains a mix of functions: some of them run under the BQL and modify the block layer graph, others are instead thread-safe and perform I/O in iothreads. It is not easy to understand which function is part of which group (I/O vs GS), and this patch aims to clarify it. The "GS"