Re: [PATCH v3 08/17] block/io: support int64_t bytes in bdrv_aligned_preadv()

2020-06-18 Thread Eric Blake
On 6/18/20 9:35 AM, Alberto Garcia wrote: On Fri 22 May 2020 05:14:36 PM CEST, Eric Blake wrote: static int coroutine_fn bdrv_aligned_preadv(BdrvChild *child, -BdrvTrackedRequest *req, int64_t offset, unsigned int bytes, +BdrvTrackedRequest *req, int64_t offset, int64_t bytes,

Re: [PATCH v3 08/17] block/io: support int64_t bytes in bdrv_aligned_preadv()

2020-06-18 Thread Alberto Garcia
On Fri 22 May 2020 05:14:36 PM CEST, Eric Blake wrote: >> static int coroutine_fn bdrv_aligned_preadv(BdrvChild *child, >> -BdrvTrackedRequest *req, int64_t offset, unsigned int bytes, >> +BdrvTrackedRequest *req, int64_t offset, int64_t bytes, >> int64_t align, QEMUIOVector *qiov,

Re: [PATCH v3 08/17] block/io: support int64_t bytes in bdrv_aligned_preadv()

2020-05-22 Thread Eric Blake
On 4/30/20 6:10 AM, Vladimir Sementsov-Ogievskiy wrote: We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be

[PATCH v3 08/17] block/io: support int64_t bytes in bdrv_aligned_preadv()

2020-04-30 Thread Vladimir Sementsov-Ogievskiy
We are generally moving to int64_t for both offset and bytes parameters on all io paths. Main motivation is realization of 64-bit write_zeroes operation for fast zeroing large disk chunks, up to the whole disk. We chose signed type, to be consistent with off_t (which is signed) and with possibili