[PATCH v3 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-10 Thread Klaus Jensen
From: Klaus Jensen Remove an unnecessary local Error value in nvme_realize(). In the process, change nvme_check_constraints() into returning a bool. Finally, removing the local Error value also fixes a bug where an error returned from nvme_init_subsys() would be lost. Reviewed-by: Philippe Math

Re: [PATCH v3 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-10 Thread Markus Armbruster
Klaus Jensen writes: > From: Klaus Jensen > > Remove an unnecessary local Error value in nvme_realize(). In the > process, change nvme_check_constraints() into returning a bool. > > Finally, removing the local Error value also fixes a bug where an error > returned from nvme_init_subsys() would b

Re: [PATCH v3 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-10 Thread Klaus Jensen
On Nov 11 07:36, Markus Armbruster wrote: > Klaus Jensen writes: > > > From: Klaus Jensen > > > > Remove an unnecessary local Error value in nvme_realize(). In the > > process, change nvme_check_constraints() into returning a bool. > > > > Finally, removing the local Error value also fixes a bug

Re: [PATCH v3 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-10 Thread Markus Armbruster
Klaus Jensen writes: > On Nov 11 07:36, Markus Armbruster wrote: >> Klaus Jensen writes: >> >> > From: Klaus Jensen >> > >> > Remove an unnecessary local Error value in nvme_realize(). In the >> > process, change nvme_check_constraints() into returning a bool. >> > >> > Finally, removing the l

Re: [PATCH v3 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-10 Thread Klaus Jensen
On Nov 11 07:55, Markus Armbruster wrote: > Klaus Jensen writes: > > > On Nov 11 07:36, Markus Armbruster wrote: > >> Klaus Jensen writes: > >> > >> > From: Klaus Jensen > >> > > >> > Remove an unnecessary local Error value in nvme_realize(). In the > >> > process, change nvme_check_constraint

Re: [PATCH v3 1/2] hw/nvme: fix incorrect use of errp/local_err

2022-11-11 Thread Markus Armbruster
Klaus Jensen writes: > On Nov 11 07:55, Markus Armbruster wrote: >> Klaus Jensen writes: >> >> > On Nov 11 07:36, Markus Armbruster wrote: >> >> Klaus Jensen writes: >> >> >> >> > From: Klaus Jensen >> >> > >> >> > Remove an unnecessary local Error value in nvme_realize(). In the >> >> > pro