Re: [PATCH v3 17/21] migration/savevm: don't worry if bitmap migration postcopy failed

2020-07-27 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: > > First, if only bitmaps postcopy enabled (not ram postcopy) > > is enabled (and not ram postcopy), > > > postcopy_pause_incoming crashes on assertion assert(mis->to_src_file). > > on an > > > >

Re: [PATCH v3 17/21] migration/savevm: don't worry if bitmap migration postcopy failed

2020-07-24 Thread Eric Blake
On 7/24/20 3:43 AM, Vladimir Sementsov-Ogievskiy wrote: First, if only bitmaps postcopy enabled (not ram postcopy) is enabled (and not ram postcopy), postcopy_pause_incoming crashes on assertion assert(mis->to_src_file). on an And anyway, bitmaps postcopy is not prepared to be somehow re

[PATCH v3 17/21] migration/savevm: don't worry if bitmap migration postcopy failed

2020-07-24 Thread Vladimir Sementsov-Ogievskiy
First, if only bitmaps postcopy enabled (not ram postcopy) postcopy_pause_incoming crashes on assertion assert(mis->to_src_file). And anyway, bitmaps postcopy is not prepared to be somehow recovered. The original idea instead is that if bitmaps postcopy failed, we just loss some bitmaps, which is