Re: [PATCH v3 2/4] qemu-img: make --block-size optional for compare --stat

2021-11-02 Thread Hanna Reitz
On 28.10.21 12:24, Vladimir Sementsov-Ogievskiy wrote: Let's detect block-size automatically if not specified by user: If both files define cluster-size, use minimum to be more precise. If both files don't specify cluster-size, use default of 64K If only one file specify cluster-size, just

Re: [PATCH v3 2/4] qemu-img: make --block-size optional for compare --stat

2021-11-01 Thread Eric Blake
On Mon, Nov 01, 2021 at 11:03:22AM +0300, Vladimir Sementsov-Ogievskiy wrote: > 29.10.2021 23:32, Eric Blake wrote: > > On Thu, Oct 28, 2021 at 12:24:39PM +0200, Vladimir Sementsov-Ogievskiy > > wrote: > > > Let's detect block-size automatically if not specified by user: > > > > > > If both fil

Re: [PATCH v3 2/4] qemu-img: make --block-size optional for compare --stat

2021-11-01 Thread Vladimir Sementsov-Ogievskiy
29.10.2021 23:32, Eric Blake wrote: On Thu, Oct 28, 2021 at 12:24:39PM +0200, Vladimir Sementsov-Ogievskiy wrote: Let's detect block-size automatically if not specified by user: If both files define cluster-size, use minimum to be more precise. If both files don't specify cluster-size, use

Re: [PATCH v3 2/4] qemu-img: make --block-size optional for compare --stat

2021-10-29 Thread Eric Blake
On Thu, Oct 28, 2021 at 12:24:39PM +0200, Vladimir Sementsov-Ogievskiy wrote: > Let's detect block-size automatically if not specified by user: > > If both files define cluster-size, use minimum to be more precise. > If both files don't specify cluster-size, use default of 64K > If only one fil

[PATCH v3 2/4] qemu-img: make --block-size optional for compare --stat

2021-10-28 Thread Vladimir Sementsov-Ogievskiy
Let's detect block-size automatically if not specified by user: If both files define cluster-size, use minimum to be more precise. If both files don't specify cluster-size, use default of 64K If only one file specify cluster-size, just use it. Signed-off-by: Vladimir Sementsov-Ogievskiy ---