Re: [PATCH v3 21/33] qemu-socket: pass monitor link to socket_get_fd directly

2021-05-13 Thread Vladimir Sementsov-Ogievskiy
12.05.2021 12:59, Daniel P. Berrangé wrote: On Wed, May 12, 2021 at 12:40:03PM +0300, Roman Kagan wrote: On Mon, Apr 19, 2021 at 10:34:49AM +0100, Daniel P. Berrangé wrote: On Fri, Apr 16, 2021 at 11:08:59AM +0300, Vladimir Sementsov-Ogievskiy wrote: Detecting monitor by current coroutine

Re: [PATCH v3 21/33] qemu-socket: pass monitor link to socket_get_fd directly

2021-05-12 Thread Daniel P . Berrangé
On Wed, May 12, 2021 at 12:40:03PM +0300, Roman Kagan wrote: > On Mon, Apr 19, 2021 at 10:34:49AM +0100, Daniel P. Berrangé wrote: > > On Fri, Apr 16, 2021 at 11:08:59AM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > Detecting monitor by current coroutine works bad when we are not in > > >

Re: [PATCH v3 21/33] qemu-socket: pass monitor link to socket_get_fd directly

2021-05-12 Thread Roman Kagan
On Mon, Apr 19, 2021 at 10:34:49AM +0100, Daniel P. Berrangé wrote: > On Fri, Apr 16, 2021 at 11:08:59AM +0300, Vladimir Sementsov-Ogievskiy wrote: > > Detecting monitor by current coroutine works bad when we are not in > > coroutine context. And that's exactly so in nbd reconnect code, where > >

Re: [PATCH v3 21/33] qemu-socket: pass monitor link to socket_get_fd directly

2021-04-19 Thread Vladimir Sementsov-Ogievskiy
19.04.2021 12:34, Daniel P. Berrangé wrote: On Fri, Apr 16, 2021 at 11:08:59AM +0300, Vladimir Sementsov-Ogievskiy wrote: Detecting monitor by current coroutine works bad when we are not in coroutine context. And that's exactly so in nbd reconnect code, where qio_channel_socket_connect_sync()

Re: [PATCH v3 21/33] qemu-socket: pass monitor link to socket_get_fd directly

2021-04-19 Thread Daniel P . Berrangé
On Fri, Apr 16, 2021 at 11:08:59AM +0300, Vladimir Sementsov-Ogievskiy wrote: > Detecting monitor by current coroutine works bad when we are not in > coroutine context. And that's exactly so in nbd reconnect code, where > qio_channel_socket_connect_sync() is called from thread. > > Add a

[PATCH v3 21/33] qemu-socket: pass monitor link to socket_get_fd directly

2021-04-16 Thread Vladimir Sementsov-Ogievskiy
Detecting monitor by current coroutine works bad when we are not in coroutine context. And that's exactly so in nbd reconnect code, where qio_channel_socket_connect_sync() is called from thread. Add a possibility to pass monitor by hand, to be used in the following commit. Signed-off-by: