Re: [PATCH v3 7/9] qcow2: Expose bitmaps' size during measure

2020-05-13 Thread Max Reitz
On 12.05.20 21:39, Eric Blake wrote: > On 5/12/20 6:10 AM, Max Reitz wrote: > > >>> This does not break old code since previously we always reported only >>> guest visible content >>> here, but it changes the semantics, and now you cannot allocate >>> "required" size, you need >>> to allocate

Re: [PATCH v3 7/9] qcow2: Expose bitmaps' size during measure

2020-05-12 Thread Eric Blake
On 5/12/20 3:35 PM, Nir Soffer wrote: First, a usage question: would you rather that 'qemu-img convert --bitmaps' silently succeeds even when the image being converted has no bitmaps, or would you rather that it fails loudly when there are no bitmaps to be copied over? I think the meaning of

Re: [PATCH v3 7/9] qcow2: Expose bitmaps' size during measure

2020-05-12 Thread Nir Soffer
On Tue, May 12, 2020 at 10:39 PM Eric Blake wrote: > > On 5/12/20 6:10 AM, Max Reitz wrote: > > > >> This does not break old code since previously we always reported only > >> guest visible content > >> here, but it changes the semantics, and now you cannot allocate > >> "required" size, you need

Re: [PATCH v3 7/9] qcow2: Expose bitmaps' size during measure

2020-05-12 Thread Eric Blake
On 5/12/20 6:10 AM, Max Reitz wrote: This does not break old code since previously we always reported only guest visible content here, but it changes the semantics, and now you cannot allocate "required" size, you need to allocate "required" size with "bitmaps" size. Only if you copy the

Re: [PATCH v3 7/9] qcow2: Expose bitmaps' size during measure

2020-05-12 Thread Max Reitz
On 12.05.20 12:17, Nir Soffer wrote: > On Fri, May 8, 2020 at 9:03 PM Eric Blake wrote: >> >> It's useful to know how much space can be occupied by qcow2 persistent >> bitmaps, even though such metadata is unrelated to the guest-visible >> data. Report this value as an additional field, present

Re: [PATCH v3 7/9] qcow2: Expose bitmaps' size during measure

2020-05-12 Thread Nir Soffer
On Fri, May 8, 2020 at 9:03 PM Eric Blake wrote: > > It's useful to know how much space can be occupied by qcow2 persistent > bitmaps, even though such metadata is unrelated to the guest-visible > data. Report this value as an additional field, present when > measuring an existing image and the

Re: [PATCH v3 7/9] qcow2: Expose bitmaps' size during measure

2020-05-11 Thread Eric Blake
On 5/11/20 6:50 AM, Max Reitz wrote: On 08.05.20 20:03, Eric Blake wrote: It's useful to know how much space can be occupied by qcow2 persistent bitmaps, even though such metadata is unrelated to the guest-visible data. Report this value as an additional field, present when measuring an

Re: [PATCH v3 7/9] qcow2: Expose bitmaps' size during measure

2020-05-11 Thread Max Reitz
On 08.05.20 20:03, Eric Blake wrote: > It's useful to know how much space can be occupied by qcow2 persistent > bitmaps, even though such metadata is unrelated to the guest-visible > data. Report this value as an additional field, present when > measuring an existing image and the output format

[PATCH v3 7/9] qcow2: Expose bitmaps' size during measure

2020-05-08 Thread Eric Blake
It's useful to know how much space can be occupied by qcow2 persistent bitmaps, even though such metadata is unrelated to the guest-visible data. Report this value as an additional field, present when measuring an existing image and the output format supports bitmaps. Update iotest 178 and 190 to