Re: [PATCH v4 04/16] virtio-scsi-test: add missing feature negotiation

2019-10-23 Thread Thomas Huth
- Original Message - > From: "Stefan Hajnoczi" > Sent: Wednesday, October 23, 2019 12:04:13 PM > > VIRTIO Device Initialization requires feature negotiation. Currently > virtio-scsi-test.c is non-compliant. > > libqos tests acknowledge all feature bits advertised by the device, >

[PATCH v4 04/16] virtio-scsi-test: add missing feature negotiation

2019-10-23 Thread Stefan Hajnoczi
VIRTIO Device Initialization requires feature negotiation. Currently virtio-scsi-test.c is non-compliant. libqos tests acknowledge all feature bits advertised by the device, except VIRTIO_F_BAD_FEATURE (which devices use to detect broken drivers!) and VIRTIO_RING_F_EVENT_IDX (which is not