Re: [PATCH v4 19/24] nvme: handle dma errors

2020-01-13 Thread Klaus Birkelund Jensen
On Jan 9 11:35, Beata Michalska wrote: > Hi Klaus, > Hi Beata, Your reviews are, as always, much appreciated! Thanks! > On Thu, 19 Dec 2019 at 13:09, Klaus Jensen wrote: > > @@ -1595,7 +1611,12 @@ static void nvme_process_sq(void *opaque) > > > > while (!(nvme_sq_empty(sq) || QTAILQ_EMPT

Re: [PATCH v4 19/24] nvme: handle dma errors

2020-01-09 Thread Beata Michalska
Hi Klaus, On Thu, 19 Dec 2019 at 13:09, Klaus Jensen wrote: > > Handling DMA errors gracefully is required for the device to pass the > block/011 test ("disable PCI device while doing I/O") in the blktests > suite. > > With this patch the device passes the test by retrying "critical" > transfers

[PATCH v4 19/24] nvme: handle dma errors

2019-12-19 Thread Klaus Jensen
Handling DMA errors gracefully is required for the device to pass the block/011 test ("disable PCI device while doing I/O") in the blktests suite. With this patch the device passes the test by retrying "critical" transfers (posting of completion entries and processing of submission queue entries).