Re: [PATCH v4 2/3] replication: acquire aio context before calling job_cancel_sync

2020-04-02 Thread Stefan Reiter
On 02/04/2020 14:41, Max Reitz wrote: On 01.04.20 10:15, Stefan Reiter wrote: job_cancel_sync requires the job's lock to be held, all other callers already do this (replication_stop, drive_backup_abort, blockdev_backup_abort, job_cancel_sync_all, cancel_common). I think all other callers come

Re: [PATCH v4 2/3] replication: acquire aio context before calling job_cancel_sync

2020-04-02 Thread Max Reitz
On 01.04.20 10:15, Stefan Reiter wrote: > job_cancel_sync requires the job's lock to be held, all other callers > already do this (replication_stop, drive_backup_abort, > blockdev_backup_abort, job_cancel_sync_all, cancel_common). I think all other callers come directly from QMP, though, so they h

[PATCH v4 2/3] replication: acquire aio context before calling job_cancel_sync

2020-04-01 Thread Stefan Reiter
job_cancel_sync requires the job's lock to be held, all other callers already do this (replication_stop, drive_backup_abort, blockdev_backup_abort, job_cancel_sync_all, cancel_common). Signed-off-by: Stefan Reiter --- block/replication.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(