Re: [PATCH v4 3/3] backup: don't acquire aio_context in backup_clean

2020-04-02 Thread Max Reitz
On 01.04.20 10:15, Stefan Reiter wrote: > All code-paths leading to backup_clean (via job_clean) have the job's > context already acquired. The job's context is guaranteed to be the same > as the one used by backup_top via backup_job_create. > > Since the previous logic effectively acquired the lo

[PATCH v4 3/3] backup: don't acquire aio_context in backup_clean

2020-04-01 Thread Stefan Reiter
All code-paths leading to backup_clean (via job_clean) have the job's context already acquired. The job's context is guaranteed to be the same as the one used by backup_top via backup_job_create. Since the previous logic effectively acquired the lock twice, this broke cleanup of backups for disks