[PATCH v4 5/5] qapi: More complex uses of QAPI_LIST_APPEND

2021-01-13 Thread Eric Blake
These cases require a bit more thought to review; in each case, the code was appending to a list, but not with a FOOList **tail variable. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- fix qmp_guest_network_get_interfaces [Vladimir] --- block/gluster.c| 13

Re: [PATCH v4 5/5] qapi: More complex uses of QAPI_LIST_APPEND

2021-02-05 Thread Eric Blake
On 1/26/21 3:31 AM, Markus Armbruster wrote: > Eric Blake writes: > >> These cases require a bit more thought to review; in each case, the >> code was appending to a list, but not with a FOOList **tail variable. >> >> Signed-off-by: Eric Blake >> Reviewed-by: Vladimir Sementsov-Ogievskiy >> >>

Re: [PATCH v4 5/5] qapi: More complex uses of QAPI_LIST_APPEND

2021-01-14 Thread Markus Armbruster
Eric Blake writes: > These cases require a bit more thought to review; in each case, the > code was appending to a list, but not with a FOOList **tail variable. > > Signed-off-by: Eric Blake > Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Markus Armbruster

Re: [PATCH v4 5/5] qapi: More complex uses of QAPI_LIST_APPEND

2021-01-26 Thread Markus Armbruster
Eric Blake writes: > These cases require a bit more thought to review; in each case, the > code was appending to a list, but not with a FOOList **tail variable. > > Signed-off-by: Eric Blake > Reviewed-by: Vladimir Sementsov-Ogievskiy > > --- > fix qmp_guest_network_get_interfaces [Vladimir] F

Re: [PATCH v4 5/5] qapi: More complex uses of QAPI_LIST_APPEND

2021-01-27 Thread Eric Blake
On 1/26/21 3:31 AM, Markus Armbruster wrote: > Eric Blake writes: > >> These cases require a bit more thought to review; in each case, the >> code was appending to a list, but not with a FOOList **tail variable. >> >> Signed-off-by: Eric Blake >> Reviewed-by: Vladimir Sementsov-Ogievskiy >> >>

Re: [PATCH v4 5/5] qapi: More complex uses of QAPI_LIST_APPEND

2021-01-27 Thread Markus Armbruster
Eric Blake writes: > On 1/26/21 3:31 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> These cases require a bit more thought to review; in each case, the >>> code was appending to a list, but not with a FOOList **tail variable. >>> >>> Signed-off-by: Eric Blake >>> Reviewed-by: Vladim