Re: [PATCH v5] qcow2: Forbid discard in qcow2 v2 images with backing files

2020-04-03 Thread Max Reitz
On 31.03.20 13:43, Alberto Garcia wrote: > A discard request deallocates the selected clusters so they read back > as zeroes. This is done by clearing the cluster offset field and > setting QCOW_OFLAG_ZERO in the L2 entry. > > This flag is however only supported when qcow_version >= 3. In older >

Re: [PATCH v5] qcow2: Forbid discard in qcow2 v2 images with backing files

2020-03-31 Thread Eric Blake
On 3/31/20 6:43 AM, Alberto Garcia wrote: A discard request deallocates the selected clusters so they read back as zeroes. This is done by clearing the cluster offset field and setting QCOW_OFLAG_ZERO in the L2 entry. This flag is however only supported when qcow_version >= 3. In older images th

[PATCH v5] qcow2: Forbid discard in qcow2 v2 images with backing files

2020-03-31 Thread Alberto Garcia
A discard request deallocates the selected clusters so they read back as zeroes. This is done by clearing the cluster offset field and setting QCOW_OFLAG_ZERO in the L2 entry. This flag is however only supported when qcow_version >= 3. In older images the cluster is simply deallocated, exposing an