Re: [PATCH v5 09/31] block: introduce assert_bdrv_graph_writable

2021-12-16 Thread Hanna Reitz
On 14.12.21 20:48, Emanuele Giuseppe Esposito wrote: On 10/12/2021 18:43, Hanna Reitz wrote: On 24.11.21 07:43, Emanuele Giuseppe Esposito wrote: We want to be sure that the functions that write the child and parent list of a bs are under BQL and drain. BQL prevents from concurrent writings

Re: [PATCH v5 09/31] block: introduce assert_bdrv_graph_writable

2021-12-14 Thread Emanuele Giuseppe Esposito
On 10/12/2021 18:43, Hanna Reitz wrote: On 24.11.21 07:43, Emanuele Giuseppe Esposito wrote: We want to be sure that the functions that write the child and parent list of a bs are under BQL and drain. BQL prevents from concurrent writings from the GS API, while drains protect from I/O.

Re: [PATCH v5 09/31] block: introduce assert_bdrv_graph_writable

2021-12-10 Thread Hanna Reitz
On 24.11.21 07:43, Emanuele Giuseppe Esposito wrote: We want to be sure that the functions that write the child and parent list of a bs are under BQL and drain. BQL prevents from concurrent writings from the GS API, while drains protect from I/O. TODO: drains are missing in some functions

[PATCH v5 09/31] block: introduce assert_bdrv_graph_writable

2021-11-23 Thread Emanuele Giuseppe Esposito
We want to be sure that the functions that write the child and parent list of a bs are under BQL and drain. BQL prevents from concurrent writings from the GS API, while drains protect from I/O. TODO: drains are missing in some functions using this assert. Therefore a proper assertion will fail.