Re: [PATCH v6 11/11] qapi: Use QAPI_LIST_ADD() where possible

2020-10-27 Thread Eric Blake
On 10/27/20 10:36 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 10/27/20 5:09 AM, Markus Armbruster wrote: >>> Eric Blake writes: >>> Anywhere we create a list of just one item or by prepending items (typically because order doesn't matter), we can use the now-public

Re: [PATCH v6 11/11] qapi: Use QAPI_LIST_ADD() where possible

2020-10-27 Thread Markus Armbruster
Eric Blake writes: > On 10/27/20 5:09 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Anywhere we create a list of just one item or by prepending items >>> (typically because order doesn't matter), we can use the now-public >>> macro. But places where we must keep the list in order

Re: [PATCH v6 11/11] qapi: Use QAPI_LIST_ADD() where possible

2020-10-27 Thread Vladimir Sementsov-Ogievskiy
27.10.2020 08:05, Eric Blake wrote: Anywhere we create a list of just one item or by prepending items (typically because order doesn't matter), we can use the now-public macro. But places where we must keep the list in order by appending remain open-coded. Signed-off-by: Eric Blake --- [..]

Re: [PATCH v6 11/11] qapi: Use QAPI_LIST_ADD() where possible

2020-10-27 Thread Eric Blake
On 10/27/20 5:09 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Anywhere we create a list of just one item or by prepending items >> (typically because order doesn't matter), we can use the now-public >> macro. But places where we must keep the list in order by appending >> remain

Re: [PATCH v6 11/11] qapi: Use QAPI_LIST_ADD() where possible

2020-10-27 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > Anywhere we create a list of just one item or by prepending items > (typically because order doesn't matter), we can use the now-public > macro. But places where we must keep the list in order by appending > remain open-coded. > > Signed-off-by: Eric

Re: [PATCH v6 11/11] qapi: Use QAPI_LIST_ADD() where possible

2020-10-27 Thread Markus Armbruster
Eric Blake writes: > Anywhere we create a list of just one item or by prepending items > (typically because order doesn't matter), we can use the now-public > macro. But places where we must keep the list in order by appending > remain open-coded. Should we rename the macro to

Re: [PATCH v6 11/11] qapi: Use QAPI_LIST_ADD() where possible

2020-10-27 Thread David Gibson
On Tue, Oct 27, 2020 at 12:05:56AM -0500, Eric Blake wrote: > Anywhere we create a list of just one item or by prepending items > (typically because order doesn't matter), we can use the now-public > macro. But places where we must keep the list in order by appending > remain open-coded. > >

Re: [PATCH v6 11/11] qapi: Use QAPI_LIST_ADD() where possible

2020-10-26 Thread Thomas Huth
On 27/10/2020 06.05, Eric Blake wrote: > Anywhere we create a list of just one item or by prepending items > (typically because order doesn't matter), we can use the now-public > macro. But places where we must keep the list in order by appending > remain open-coded. > > Signed-off-by: Eric

[PATCH v6 11/11] qapi: Use QAPI_LIST_ADD() where possible

2020-10-26 Thread Eric Blake
Anywhere we create a list of just one item or by prepending items (typically because order doesn't matter), we can use the now-public macro. But places where we must keep the list in order by appending remain open-coded. Signed-off-by: Eric Blake --- docs/devel/writing-qmp-commands.txt | 13