12.03.2020 10:23, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
11.03.2020 17:41, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
11.03.2020 12:38, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
09.03.2020 12:56, Markus Armbruster wrote:
Su
Vladimir Sementsov-Ogievskiy writes:
> 11.03.2020 17:41, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 11.03.2020 12:38, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
> 09.03.2020 12:56, Markus Armbruster wrote:
>> Suggest
>>
>
11.03.2020 17:41, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
11.03.2020 12:38, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
09.03.2020 12:56, Markus Armbruster wrote:
Suggest
scripts: Coccinelle script to use auto-propagated errp
or
scr
Vladimir Sementsov-Ogievskiy writes:
> 11.03.2020 12:38, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 09.03.2020 12:56, Markus Armbruster wrote:
Suggest
scripts: Coccinelle script to use auto-propagated errp
or
scripts: Co
11.03.2020 12:38, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
09.03.2020 12:56, Markus Armbruster wrote:
Suggest
scripts: Coccinelle script to use auto-propagated errp
or
scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()
Vladimir Sementsov-Ogievskiy wr
11.03.2020 12:53, Markus Armbruster wrote:
I think a v9 makes sense now.
If any of the improvement ideas should turn into time sinks for you,
let's talk. We don't need perfection, we only need to get to the point
where we trust the script to do what we believe it does, understand its
limitation
I think a v9 makes sense now.
If any of the improvement ideas should turn into time sinks for you,
let's talk. We don't need perfection, we only need to get to the point
where we trust the script to do what we believe it does, understand its
limitations, and know how to compensate for them.
Righ
11.03.2020 12:33, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
09.03.2020 12:56, Markus Armbruster wrote:
+
+// Convert error clearing functions
Suggest: Ensure @local_err is cleared on free
But there is no local_err after conversion
True. Hmm. What about this:
Vladimir Sementsov-Ogievskiy writes:
> 09.03.2020 12:56, Markus Armbruster wrote:
>> Suggest
>>
>> scripts: Coccinelle script to use auto-propagated errp
>>
>> or
>>
>> scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()
>>
>> Vladimir Sementsov-Ogievskiy writes:
[...]
>>> +// Note
Vladimir Sementsov-Ogievskiy writes:
> 09.03.2020 12:56, Markus Armbruster wrote:
>>> +
>>> +// Convert error clearing functions
>> Suggest: Ensure @local_err is cleared on free
>
> But there is no local_err after conversion
True. Hmm. What about this:
// Convert calls to error_free(), p
11.03.2020 12:04, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
10.03.2020 18:47, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
09.03.2020 12:56, Markus Armbruster wrote:
Suggest
scripts: Coccinelle script to use auto-propagated errp
or
scr
Vladimir Sementsov-Ogievskiy writes:
> 10.03.2020 18:47, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> 09.03.2020 12:56, Markus Armbruster wrote:
Suggest
scripts: Coccinelle script to use auto-propagated errp
or
scripts: Co
09.03.2020 12:56, Markus Armbruster wrote:
+
+// Convert error clearing functions
Suggest: Ensure @local_err is cleared on free
But there is no local_err after conversion
+(
+-error_free(local_err);
++error_free_errp(errp);
+|
+-error_report_err(local_err);
++error_report_e
11.03.2020 9:55, Vladimir Sementsov-Ogievskiy wrote:
10.03.2020 18:47, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
09.03.2020 12:56, Markus Armbruster wrote:
Suggest
scripts: Coccinelle script to use auto-propagated errp
or
scripts: Coccinelle script to use E
09.03.2020 12:56, Markus Armbruster wrote:
Suggest
scripts: Coccinelle script to use auto-propagated errp
or
scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()
Vladimir Sementsov-Ogievskiy writes:
Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and
does co
10.03.2020 18:47, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
09.03.2020 12:56, Markus Armbruster wrote:
Suggest
scripts: Coccinelle script to use auto-propagated errp
or
scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()
Vladimir Sementsov-Ogievskiy wr
Vladimir Sementsov-Ogievskiy writes:
> 09.03.2020 12:56, Markus Armbruster wrote:
>> Suggest
>>
>> scripts: Coccinelle script to use auto-propagated errp
>>
>> or
>>
>> scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()
>>
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> Script adds
09.03.2020 12:56, Markus Armbruster wrote:
Suggest
scripts: Coccinelle script to use auto-propagated errp
or
scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()
Vladimir Sementsov-Ogievskiy writes:
Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and
does co
08.03.2020 22:09, Christian Schoenebeck wrote:
On Freitag, 6. März 2020 06:15:28 CET Vladimir Sementsov-Ogievskiy wrote:
diff --git a/scripts/coccinelle/auto-propagated-errp.cocci
b/scripts/coccinelle/auto-propagated-errp.cocci new file mode 100644
index 00..bff274bd6d
--- /dev/null
+++
Suggest
scripts: Coccinelle script to use auto-propagated errp
or
scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()
Vladimir Sementsov-Ogievskiy writes:
> Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and
> does corresponding changes in code (look for detail
On Freitag, 6. März 2020 06:15:28 CET Vladimir Sementsov-Ogievskiy wrote:
> diff --git a/scripts/coccinelle/auto-propagated-errp.cocci
> b/scripts/coccinelle/auto-propagated-errp.cocci new file mode 100644
> index 00..bff274bd6d
> --- /dev/null
> +++ b/scripts/coccinelle/auto-propagated-err
On 3/5/20 11:15 PM, Vladimir Sementsov-Ogievskiy wrote:
Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and
does corresponding changes in code (look for details in
include/qapi/error.h)
Usage example:
spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \
--macro-f
Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and
does corresponding changes in code (look for details in
include/qapi/error.h)
Usage example:
spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \
--macro-file scripts/cocci-macro-file.h --in-place --no-show-diff \
23 matches
Mail list logo
