[PATCH v8 13/20] jobs: group together API calls under the same job lock

2022-06-29 Thread Emanuele Giuseppe Esposito
Now that the API offers also _locked() functions, take advantage of it and give also the caller control to take the lock and call _locked functions. This makes sense especially when we have for loops, because it makes no sense to have: for(job = job_next(); ...) where each job_next() takes the l

Re: [PATCH v8 13/20] jobs: group together API calls under the same job lock

2022-07-05 Thread Stefan Hajnoczi
On Wed, Jun 29, 2022 at 10:15:31AM -0400, Emanuele Giuseppe Esposito wrote: > diff --git a/blockdev.c b/blockdev.c > index 71f793c4ab..5b79093155 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -150,12 +150,15 @@ void blockdev_mark_auto_del(BlockBackend *blk) > return; > } > > -

Re: [PATCH v8 13/20] jobs: group together API calls under the same job lock

2022-07-05 Thread Emanuele Giuseppe Esposito
Am 05/07/2022 um 10:14 schrieb Stefan Hajnoczi: > On Wed, Jun 29, 2022 at 10:15:31AM -0400, Emanuele Giuseppe Esposito wrote: >> diff --git a/blockdev.c b/blockdev.c >> index 71f793c4ab..5b79093155 100644 >> --- a/blockdev.c >> +++ b/blockdev.c >> @@ -150,12 +150,15 @@ void blockdev_mark_auto_de

Re: [PATCH v8 13/20] jobs: group together API calls under the same job lock

2022-07-05 Thread Emanuele Giuseppe Esposito
Am 05/07/2022 um 10:17 schrieb Emanuele Giuseppe Esposito: > > > Am 05/07/2022 um 10:14 schrieb Stefan Hajnoczi: >> On Wed, Jun 29, 2022 at 10:15:31AM -0400, Emanuele Giuseppe Esposito wrote: >>> diff --git a/blockdev.c b/blockdev.c >>> index 71f793c4ab..5b79093155 100644 >>> --- a/blockdev.c

Re: [PATCH v8 13/20] jobs: group together API calls under the same job lock

2022-07-05 Thread Vladimir Sementsov-Ogievskiy
On 7/5/22 16:01, Emanuele Giuseppe Esposito wrote: Am 05/07/2022 um 10:17 schrieb Emanuele Giuseppe Esposito: Am 05/07/2022 um 10:14 schrieb Stefan Hajnoczi: On Wed, Jun 29, 2022 at 10:15:31AM -0400, Emanuele Giuseppe Esposito wrote: diff --git a/blockdev.c b/blockdev.c index 71f793c4ab..5

Re: [PATCH v8 13/20] jobs: group together API calls under the same job lock

2022-07-05 Thread Vladimir Sementsov-Ogievskiy
On 6/29/22 17:15, Emanuele Giuseppe Esposito wrote: --- a/job.c +++ b/job.c @@ -1045,11 +1045,14 @@ static void job_completed_txn_abort_locked(Job *job) /* Called with job_mutex held, but releases it temporarily */ static int job_prepare_locked(Job *job) { +int ret; + GLOBAL_STATE

Re: [PATCH v8 13/20] jobs: group together API calls under the same job lock

2022-07-06 Thread Stefan Hajnoczi
On Tue, Jul 05, 2022 at 04:22:41PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 7/5/22 16:01, Emanuele Giuseppe Esposito wrote: > > > > > > Am 05/07/2022 um 10:17 schrieb Emanuele Giuseppe Esposito: > > > > > > > > > Am 05/07/2022 um 10:14 schrieb Stefan Hajnoczi: > > > > On Wed, Jun 29, 202