Re: [PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace Command Set

2020-12-08 Thread Klaus Jensen
On Dec 8 20:02, Dmitry Fomichev wrote: > Hi Klaus, > > Thank you for your review! Please see replies below... > > > On Thu, 2020-11-12 at 20:36 +0100, Klaus Jensen wrote: > > Hi Dmitry, > > > > I know you posted v10, but my comments should be relevant to that as > > well. > > > > On Nov 5 11

Re: [PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace Command Set

2020-12-08 Thread Dmitry Fomichev
Hi Klaus, Thank you for your review! Please see replies below... On Thu, 2020-11-12 at 20:36 +0100, Klaus Jensen wrote: > Hi Dmitry, > > I know you posted v10, but my comments should be relevant to that as > well. > > On Nov 5 11:53, Dmitry Fomichev wrote: > > The emulation code has been chan

Re: [PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace Command Set

2020-11-25 Thread Klaus Jensen
On Nov 17 16:32, Keith Busch wrote: > On Thu, Nov 12, 2020 at 08:36:39PM +0100, Klaus Jensen wrote: > > On Nov 5 11:53, Dmitry Fomichev wrote: > > > @@ -133,6 +300,12 @@ static Property nvme_ns_props[] = { > > > DEFINE_BLOCK_PROPERTIES(NvmeNamespace, blkconf), > > > DEFINE_PROP_UINT32("n

Re: [PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace Command Set

2020-11-17 Thread Keith Busch
On Thu, Nov 12, 2020 at 08:36:39PM +0100, Klaus Jensen wrote: > On Nov 5 11:53, Dmitry Fomichev wrote: > > @@ -133,6 +300,12 @@ static Property nvme_ns_props[] = { > > DEFINE_BLOCK_PROPERTIES(NvmeNamespace, blkconf), > > DEFINE_PROP_UINT32("nsid", NvmeNamespace, params.nsid, 0), > >

Re: [PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace Command Set

2020-11-12 Thread Klaus Jensen
Hi Dmitry, I know you posted v10, but my comments should be relevant to that as well. On Nov 5 11:53, Dmitry Fomichev wrote: > The emulation code has been changed to advertise NVM Command Set when > "zoned" device property is not set (default) and Zoned Namespace > Command Set otherwise. > > De

RE: [PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace Command Set

2020-11-06 Thread Dmitry Fomichev
Bjorling > ; Damien Le Moal ; > qemu-block@nongnu.org; qemu-de...@nongnu.org > Subject: Re: [PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace > Command Set > > On Thu, Nov 05, 2020 at 11:53:38AM +0900, Dmitry Fomichev wrote: > > The emulation code has been changed to

Re: [PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace Command Set

2020-11-06 Thread Niklas Cassel
On Thu, Nov 05, 2020 at 11:53:38AM +0900, Dmitry Fomichev wrote: > The emulation code has been changed to advertise NVM Command Set when > "zoned" device property is not set (default) and Zoned Namespace > Command Set otherwise. > > Define values and structures that are needed to support Zoned > N

[PATCH v9 08/12] hw/block/nvme: Support Zoned Namespace Command Set

2020-11-04 Thread Dmitry Fomichev
The emulation code has been changed to advertise NVM Command Set when "zoned" device property is not set (default) and Zoned Namespace Command Set otherwise. Define values and structures that are needed to support Zoned Namespace Command Set (NVMe TP 4053) in PCI NVMe controller emulator. Define t