Re: [PULL 33/36] block/backup: use backup-top instead of write notifiers

2019-10-17 Thread Vladimir Sementsov-Ogievskiy
17.10.2019 15:04, Peter Maydell wrote: > On Thu, 10 Oct 2019 at 12:44, Max Reitz wrote: >> >> From: Vladimir Sementsov-Ogievskiy >> >> Drop write notifiers and use filter node instead. > > Hi; after this change Coverity complains about dead code in > backup_job_create() (CID 1406402): Oops, I'm

Re: [PULL 33/36] block/backup: use backup-top instead of write notifiers

2019-10-17 Thread Peter Maydell
On Thu, 10 Oct 2019 at 12:44, Max Reitz wrote: > > From: Vladimir Sementsov-Ogievskiy > > Drop write notifiers and use filter node instead. Hi; after this change Coverity complains about dead code in backup_job_create() (CID 1406402): > @@ -382,6 +353,8 @@ BlockJob *backup_job_create(const char

[PULL 33/36] block/backup: use backup-top instead of write notifiers

2019-10-10 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Drop write notifiers and use filter node instead. = Changes = 1. Add filter-node-name argument for backup qmp api. We have to do it in this commit, as 257 needs to be fixed. 2. There are no more write notifiers here, so is_write_notifier parameter is dropped