[Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

2017-02-17 Thread Pankaj Gupta
To maintain consistency at all the places use qemu_madvise wrapper inplace of madvise call. Signed-off-by: Pankaj Gupta --- block/qcow2-cache.c | 2 +- migration/postcopy-ram.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c

Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

2017-02-17 Thread Kevin Wolf
Am 17.02.2017 um 09:06 hat Pankaj Gupta geschrieben: > To maintain consistency at all the places use qemu_madvise wrapper > inplace of madvise call. > > Signed-off-by: Pankaj Gupta Reviewed-by: Kevin Wolf Juan/Dave, if one of you can give an Acked-by, I can take this through my tree. Kevin

Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

2017-02-17 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 17.02.2017 um 09:06 hat Pankaj Gupta geschrieben: > > To maintain consistency at all the places use qemu_madvise wrapper > > inplace of madvise call. > > > > Signed-off-by: Pankaj Gupta > > Reviewed-by: Kevin Wolf > > Juan/Dave, if one of you can g

Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

2017-02-17 Thread Alberto Garcia
On Fri 17 Feb 2017 09:06:04 AM CET, Pankaj Gupta wrote: > To maintain consistency at all the places use qemu_madvise wrapper > inplace of madvise call. > if (length > 0) { > -madvise((uint8_t *) t + offset, length, MADV_DONTNEED); > +qemu_madvise((uint8_t *) t + offset, leng

Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

2017-02-17 Thread Pankaj Gupta
Thanks for your comments. I have below query. > > On Fri 17 Feb 2017 09:06:04 AM CET, Pankaj Gupta wrote: > > To maintain consistency at all the places use qemu_madvise wrapper > > inplace of madvise call. > > > if (length > 0) { > > -madvise((uint8_t *) t + offset, length, MADV_D

Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

2017-02-17 Thread Dr. David Alan Gilbert
* Pankaj Gupta (pagu...@redhat.com) wrote: > > Thanks for your comments. I have below query. > > > > On Fri 17 Feb 2017 09:06:04 AM CET, Pankaj Gupta wrote: > > > To maintain consistency at all the places use qemu_madvise wrapper > > > inplace of madvise call. > > > > > if (length > 0) {

Re: [Qemu-block] [PATCH] block, migration: Use qemu_madvise inplace of madvise

2017-02-17 Thread Alberto Garcia
On Fri 17 Feb 2017 12:30:28 PM CET, Pankaj Gupta wrote: >> > To maintain consistency at all the places use qemu_madvise wrapper >> > inplace of madvise call. >> >> > -madvise((uint8_t *) t + offset, length, MADV_DONTNEED); >> > +qemu_madvise((uint8_t *) t + offset, length, QEMU_M