Re: [Qemu-block] [PATCH] block/qcow2: fix logic around dirty_bitmaps_loaded

2018-06-20 Thread Vladimir Sementsov-Ogievskiy
20.06.2018 20:17, Vladimir Sementsov-Ogievskiy wrote: 13.06.2018 01:18, John Snow wrote: On 06/12/2018 06:11 PM, John Snow wrote: On 06/12/2018 01:26 PM, Vladimir Sementsov-Ogievskiy wrote: First: this variable was introduced to handle reopens. We need it on following qcow2_do_open, to don't

Re: [Qemu-block] [PATCH] block/qcow2: fix logic around dirty_bitmaps_loaded

2018-06-20 Thread Vladimir Sementsov-Ogievskiy
13.06.2018 01:18, John Snow wrote: On 06/12/2018 06:11 PM, John Snow wrote: On 06/12/2018 01:26 PM, Vladimir Sementsov-Ogievskiy wrote: First: this variable was introduced to handle reopens. We need it on following qcow2_do_open, to don't try loading bitmaps again. So, we are fixing qcow2_inv

Re: [Qemu-block] [PATCH] block/qcow2: fix logic around dirty_bitmaps_loaded

2018-06-12 Thread John Snow
On 06/12/2018 06:11 PM, John Snow wrote: > > > On 06/12/2018 01:26 PM, Vladimir Sementsov-Ogievskiy wrote: >> First: this variable was introduced to handle reopens. We need it on >> following qcow2_do_open, to don't try loading bitmaps again. So, we are >> fixing qcow2_invalidate_cache(). >> >

Re: [Qemu-block] [PATCH] block/qcow2: fix logic around dirty_bitmaps_loaded

2018-06-12 Thread John Snow
On 06/12/2018 01:26 PM, Vladimir Sementsov-Ogievskiy wrote: > First: this variable was introduced to handle reopens. We need it on > following qcow2_do_open, to don't try loading bitmaps again. So, we are > fixing qcow2_invalidate_cache(). > > However, if we fix only qcow2_invalidate_cache, iot

[Qemu-block] [PATCH] block/qcow2: fix logic around dirty_bitmaps_loaded

2018-06-12 Thread Vladimir Sementsov-Ogievskiy
First: this variable was introduced to handle reopens. We need it on following qcow2_do_open, to don't try loading bitmaps again. So, we are fixing qcow2_invalidate_cache(). However, if we fix only qcow2_invalidate_cache, iotest 169 fails on case test__persistent__not_migbitmap__online_shared, bec