Re: [Qemu-block] [PATCH] block/ssh: Fix the regression of unused parameter

2016-11-02 Thread Ashijeet Acharya
On Wed, Nov 2, 2016 at 4:03 PM, Kevin Wolf wrote: > Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben: >> This patch drops the unused parameter "BDRVSSHState" being passed into >> the ssh_config() function and fixes the bug. >> >> Signed-off-by: Ashijeet Acharya > > The patch looks good, bu

Re: [Qemu-block] [PATCH] block/ssh: Fix the regression of unused parameter

2016-11-02 Thread Kevin Wolf
Am 31.10.2016 um 19:06 hat Ashijeet Acharya geschrieben: > This patch drops the unused parameter "BDRVSSHState" being passed into > the ssh_config() function and fixes the bug. > > Signed-off-by: Ashijeet Acharya The patch looks good, but why do claim that this is a bug fix rather than just a co

[Qemu-block] [PATCH] block/ssh: Fix the regression of unused parameter

2016-10-31 Thread Ashijeet Acharya
This patch drops the unused parameter "BDRVSSHState" being passed into the ssh_config() function and fixes the bug. Signed-off-by: Ashijeet Acharya --- block/ssh.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index ca071c5..15ed281 100644 ---