Re: [Qemu-block] [PATCH] block: Silence Coverity in bdrv_drop_intermediate()

2019-03-15 Thread Alberto Garcia
On Fri 15 Mar 2019 12:18:43 PM CET, Kevin Wolf wrote: > Coverity doesn't like that the return value of bdrv_check_update_perm() > stays unused only in this place (CID 1399710). > > Even if checking local_err should be equivalent to checking ret < 0, > let's switch to using the return value to be m

[Qemu-block] [PATCH] block: Silence Coverity in bdrv_drop_intermediate()

2019-03-15 Thread Kevin Wolf
Coverity doesn't like that the return value of bdrv_check_update_perm() stays unused only in this place (CID 1399710). Even if checking local_err should be equivalent to checking ret < 0, let's switch to using the return value to be more consistent (and in case of a bug somewhere down the call cha