On Mon 16 Nov 2015 04:46:44 AM CET, Stefan Hajnoczi wrote:
>> early_err:
>> qemu_opts_del(opts);
>> +QDECREF(interval_dict);
>> +QDECREF(interval_list);
>
> There is a codepath that reaches here without initializing interval_dict
> or interval_list:
>
> qemu_opts_absorb_qdict(opts,
On Fri, Nov 13, 2015 at 11:50:03AM +0100, Alberto Garcia wrote:
> On Fri 13 Nov 2015 11:15:52 AM CET, Stefan Hajnoczi
> wrote:
> > blockdev.c: In function ‘blockdev_init’:
> > blockdev.c:636:17: error: ‘length’ may be used uninitialized in this
> > function [-Werror=maybe-uninitialized]
> >
On Wed, Nov 11, 2015 at 03:17:12PM +0200, Alberto Garcia wrote:
> @@ -583,32 +592,48 @@ static BlockBackend *blockdev_init(const char *file,
> QDict *bs_opts,
>
> block_acct_init(blk_get_stats(blk), account_invalid, account_failed);
>
> -if (stats_intervals) {
> -c
On Fri 13 Nov 2015 11:15:52 AM CET, Stefan Hajnoczi wrote:
> blockdev.c: In function ‘blockdev_init’:
> blockdev.c:636:17: error: ‘length’ may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> block_acct_add_interval(blk_get_stats(blk), length);
>
On Wed, Nov 11, 2015 at 03:17:12PM +0200, Alberto Garcia wrote:
> This is the natural JSON representation and prevents us from having to
> decode the list manually.
>
> Signed-off-by: Alberto Garcia
> ---
> blockdev.c | 64
> ++
> qapi
This is the natural JSON representation and prevents us from having to
decode the list manually.
Signed-off-by: Alberto Garcia
---
blockdev.c | 64 ++
qapi/block-core.json | 7 +++---
tests/qemu-iotests/136 | 2 +-
3 files changed,
