Re: [Qemu-block] [PATCH] test-replication: Lock AioContext around blk_unref()

2018-10-01 Thread Paolo Bonzini
On 01/10/2018 18:03, Kevin Wolf wrote: >> Given the backtrace, I think bdrv_close should be taking the AioContext >> lock instead of blockdev_close_all_bdrv_states. > Conversely, that would mean that calling bdrv_unref() with the > AioContext lock held is a bug (because close callbacks can involve

Re: [Qemu-block] [PATCH] test-replication: Lock AioContext around blk_unref()

2018-10-01 Thread Kevin Wolf
Am 01.10.2018 um 17:40 hat Paolo Bonzini geschrieben: > On 01/10/2018 16:32, Kevin Wolf wrote: > > Recently, the test case has started failing because some job related > > functions want to drop the AioContext lock even though it hasn't been > > taken: > > > > (gdb) bt > > #0 0x7f51c0

Re: [Qemu-block] [PATCH] test-replication: Lock AioContext around blk_unref()

2018-10-01 Thread Paolo Bonzini
On 01/10/2018 16:32, Kevin Wolf wrote: > Recently, the test case has started failing because some job related > functions want to drop the AioContext lock even though it hasn't been > taken: > > (gdb) bt > #0 0x7f51c067c9fb in raise () from /lib64/libc.so.6 > #1 0x7f51c067e77

[Qemu-block] [PATCH] test-replication: Lock AioContext around blk_unref()

2018-10-01 Thread Kevin Wolf
Recently, the test case has started failing because some job related functions want to drop the AioContext lock even though it hasn't been taken: (gdb) bt #0 0x7f51c067c9fb in raise () from /lib64/libc.so.6 #1 0x7f51c067e77d in abort () from /lib64/libc.so.6 #2 0x558