[Qemu-block] [PATCH] vvfat: Fix inherit_options flags

2018-03-14 Thread Fam Zheng
Overriding flags violates the precedence rules of bdrv_reopen_queue_child. Just like the read-only option, no-flush should be put into the options. The same is done in bdrv_temp_snapshot_options. Reported-by: Stefan Hajnoczi --- block/vvfat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-block] [PATCH] vvfat: Fix inherit_options flags

2018-03-15 Thread Kevin Wolf
Am 15.03.2018 um 04:45 hat Fam Zheng geschrieben: > Overriding flags violates the precedence rules of > bdrv_reopen_queue_child. Just like the read-only option, no-flush should > be put into the options. The same is done in bdrv_temp_snapshot_options. > > Reported-by: Stefan Hajnoczi Signed-off-b

Re: [Qemu-block] [PATCH] vvfat: Fix inherit_options flags

2018-03-16 Thread Stefan Hajnoczi
On Thu, Mar 15, 2018 at 11:45:07AM +0800, Fam Zheng wrote: > Overriding flags violates the precedence rules of > bdrv_reopen_queue_child. Just like the read-only option, no-flush should > be put into the options. The same is done in bdrv_temp_snapshot_options. > > Reported-by: Stefan Hajnoczi ' wh