Re: [Qemu-block] [PATCH 0/3] Add 'blockdev-del' command

2015-10-22 Thread Alberto Garcia
On Thu 22 Oct 2015 12:38:24 PM CEST, Kevin Wolf wrote: >> >> > I haven't thought about it enough yet, but it seems to me that we >> >> > can't do the BDS/BB aliasing with blockdev-del, but need to interpret >> >> > node-name as BDS and id as BB. Perhaps we also shouldn't use a

Re: [Qemu-block] [PATCH 0/3] Add 'blockdev-del' command

2015-10-22 Thread Kevin Wolf
Am 22.10.2015 um 13:31 hat Alberto Garcia geschrieben: > On Thu 22 Oct 2015 01:25:05 PM CEST, Kevin Wolf wrote: > >> But there's this case that is not so obvious. It involves the new > >> 'blockdev-snapshot' command I'm working on: > >> > >> - blockdev-add id=drive0 node-name=node0

Re: [Qemu-block] [PATCH 0/3] Add 'blockdev-del' command

2015-10-22 Thread Kevin Wolf
Am 22.10.2015 um 13:08 hat Alberto Garcia geschrieben: > >> I'm currently thinking about d), which tries to maintain the symmetry > >> with blockdev-add: > >> > >> - blockdev-del would have two parameters, 'id' and 'node-name', and only > >> one of them can be set, so you must choose whether

Re: [Qemu-block] [PATCH 0/3] Add 'blockdev-del' command

2015-10-22 Thread Alberto Garcia
On Thu 22 Oct 2015 01:25:05 PM CEST, Kevin Wolf wrote: >> But there's this case that is not so obvious. It involves the new >> 'blockdev-snapshot' command I'm working on: >> >> - blockdev-add id=drive0 node-name=node0 file=hd0.qcow2 >> - qemu-img create -f qcow2 -b hd0.qcow2 overlay0.qcow2 >>

Re: [Qemu-block] [PATCH 0/3] Add 'blockdev-del' command

2015-10-22 Thread Kevin Wolf
Am 20.10.2015 um 17:02 hat Alberto Garcia geschrieben: > On Mon 19 Oct 2015 05:04:50 PM CEST, Kevin Wolf wrote: > >> > So we seem to have two criteria to distinguish BDSes: > >> > > >> > 1. Does/Doesn't have a BlockBackend on top. > >> >In the future, multiple BlockBackends

Re: [Qemu-block] [PATCH 0/3] Add 'blockdev-del' command

2015-10-20 Thread Alberto Garcia
On Mon 19 Oct 2015 05:04:50 PM CEST, Kevin Wolf wrote: >> > So we seem to have two criteria to distinguish BDSes: >> > >> > 1. Does/Doesn't have a BlockBackend on top. >> >In the future, multiple BlockBackends are possible, too. >> >> One single BDS attached to multiple

Re: [Qemu-block] [PATCH 0/3] Add 'blockdev-del' command

2015-10-19 Thread Kevin Wolf
Am 13.10.2015 um 15:48 hat Alberto Garcia geschrieben: > Here's my first attempt at the 'blockdev-del' command. > > This series goes on top of Max's "BlockBackend and media" v6: > > https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg02810.html > > With Max's code, 'blockdev-add' can now

Re: [Qemu-block] [PATCH 0/3] Add 'blockdev-del' command

2015-10-19 Thread Max Reitz
On 19.10.2015 13:27, Kevin Wolf wrote: > Am 13.10.2015 um 15:48 hat Alberto Garcia geschrieben: >> Here's my first attempt at the 'blockdev-del' command. >> >> This series goes on top of Max's "BlockBackend and media" v6: >> >> https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg02810.html >>

Re: [Qemu-block] [PATCH 0/3] Add 'blockdev-del' command

2015-10-19 Thread Kevin Wolf
Am 19.10.2015 um 16:15 hat Alberto Garcia geschrieben: > On Mon 19 Oct 2015 01:27:45 PM CEST, Kevin Wolf wrote: > > I've been thinking a bit about the creation and deletion of > > BlockBackends a bit last week, and honestly it still feels a bit messy > > (or maybe I just don't fully understand it

[Qemu-block] [PATCH 0/3] Add 'blockdev-del' command

2015-10-13 Thread Alberto Garcia
Here's my first attempt at the 'blockdev-del' command. This series goes on top of Max's "BlockBackend and media" v6: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg02810.html With Max's code, 'blockdev-add' can now create a BlockDriverState with or without a BlockBackend (depending on