On 24 July 2015 at 06:10, Paolo Bonzini pbonz...@redhat.com wrote:
On 23/07/2015 22:10, Peter Maydell wrote:
The series looks good, but I'd prefer (especially for patch 4 which is
in a fast path) if pow2ceil and pow2floor were made inline.
Yeah, I was wondering if I was going to be asked
On 24/07/2015 10:39, Peter Maydell wrote:
But in patch 4 the call is only in the rare case where l (l - 1) is
not zero.
True. Any preferences for which header file to put them in?
qemu-common.h is where the prototype is currently and where
the inline is_power_of_2() is defined...
Either
We have a qemu_fls() function which is just a silly wrapper
around clz32() and which is used in only a handful of places
in the codebase. It turns out that all of those are really
trying to round up or down to a power of 2, which is something
we have utility functions for. This series replaces all
On 23/07/2015 22:10, Peter Maydell wrote:
The series looks good, but I'd prefer (especially for patch 4 which is
in a fast path) if pow2ceil and pow2floor were made inline.
Yeah, I was wondering if I was going to be asked to do that.
Note that qemu_fls() is/was *not* inline, though, so
On 23/07/2015 13:08, Peter Maydell wrote:
We have a qemu_fls() function which is just a silly wrapper
around clz32() and which is used in only a handful of places
in the codebase. It turns out that all of those are really
trying to round up or down to a power of 2, which is something
we
On 23/07/2015 13:08, Peter Maydell wrote:
We have a qemu_fls() function which is just a silly wrapper
around clz32() and which is used in only a handful of places
in the codebase. It turns out that all of those are really
trying to round up or down to a power of 2, which is something
we
