[Qemu-block] [PATCH 02/21] backup: init copy_bitmap from sync_bitmap for incremental

2016-12-23 Thread Vladimir Sementsov-Ogievskiy
We should not copy non-dirty clusters in write notifiers. So, initialize copy_bitmap from sync_bitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/block/backup.c b/block/backup

Re: [Qemu-block] [PATCH 02/21] backup: init copy_bitmap from sync_bitmap for incremental

2017-01-23 Thread Fam Zheng
On Fri, 12/23 17:28, Vladimir Sementsov-Ogievskiy wrote: > We should not copy non-dirty clusters in write notifiers. So, > initialize copy_bitmap from sync_bitmap. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/backup.c | 32 +++- > 1 file changed, 31 i

Re: [Qemu-block] [PATCH 02/21] backup: init copy_bitmap from sync_bitmap for incremental

2017-01-24 Thread Vladimir Sementsov-Ogievskiy
24.01.2017 10:09, Fam Zheng wrote: On Fri, 12/23 17:28, Vladimir Sementsov-Ogievskiy wrote: We should not copy non-dirty clusters in write notifiers. So, initialize copy_bitmap from sync_bitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 32 +

Re: [Qemu-block] [PATCH 02/21] backup: init copy_bitmap from sync_bitmap for incremental

2017-01-24 Thread Fam Zheng
On Tue, 01/24 12:00, Vladimir Sementsov-Ogievskiy wrote: > > > static void coroutine_fn backup_run(void *opaque) > > > { > > > BackupBlockJob *job = opaque; > > > @@ -453,20 +481,22 @@ static void coroutine_fn backup_run(void *opaque) > > > end = DIV_ROUND_UP(job->common.len, job->c

Re: [Qemu-block] [PATCH 02/21] backup: init copy_bitmap from sync_bitmap for incremental

2017-01-24 Thread Vladimir Sementsov-Ogievskiy
24.01.2017 12:46, Fam Zheng wrote: On Tue, 01/24 12:00, Vladimir Sementsov-Ogievskiy wrote: static void coroutine_fn backup_run(void *opaque) { BackupBlockJob *job = opaque; @@ -453,20 +481,22 @@ static void coroutine_fn backup_run(void *opaque) end = DIV_ROUND_UP(job->common

Re: [Qemu-block] [PATCH 02/21] backup: init copy_bitmap from sync_bitmap for incremental

2017-01-31 Thread Stefan Hajnoczi
On Fri, Dec 23, 2016 at 05:28:45PM +0300, Vladimir Sementsov-Ogievskiy wrote: > +/* init copy_bitmap from sync_bitmap */ > +static void backup_incremental_init_copy_bitmap(BackupBlockJob *job) > +{ > +int64_t sector; > +BdrvDirtyBitmapIter *dbi; > +uint32_t sect_gran = > +bdrv_d