Re: [Qemu-block] [PATCH 2/7] curl: never invoke callbacks with s->mutex held

On Wed, May 10, 2017 at 04:32:00PM +0200, Paolo Bonzini wrote: > All curl callbacks go through curl_multi_do, and hence are called with > s->mutex held. Note that with comments, and make curl_read_cb drop the > lock before invoking the callback. > > Likewise for curl_find_buf, where the callback

Re: [Qemu-block] [PATCH 2/7] curl: never invoke callbacks with s->mutex held

On 10.05.2017 16:32, Paolo Bonzini wrote: > All curl callbacks go through curl_multi_do, and hence are called with > s->mutex held. Note that with comments, and make curl_read_cb drop the > lock before invoking the callback. > > Likewise for curl_find_buf, where the callback can be invoked by the

[Qemu-block] [PATCH 2/7] curl: never invoke callbacks with s->mutex held

All curl callbacks go through curl_multi_do, and hence are called with s->mutex held. Note that with comments, and make curl_read_cb drop the lock before invoking the callback. Likewise for curl_find_buf, where the callback can be invoked by the caller. Cc: qemu-sta...@nongnu.org Cc: jc...@redha