Re: [Qemu-block] [PATCH 3/3] qcow2: reorder fields in Qcow2CachedTable to reduce padding

Am 29.05.2015 um 11:24 hat Alberto Garcia geschrieben: > Changing the current ordering saves 8 bytes per cache entry in x86_64. > > Signed-off-by: Alberto Garcia > Reviewed-by: Max Reitz > Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf

[Qemu-block] [PATCH 3/3] qcow2: reorder fields in Qcow2CachedTable to reduce padding

Changing the current ordering saves 8 bytes per cache entry in x86_64. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz Reviewed-by: Eric Blake --- block/qcow2-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c index a215f5

[Qemu-block] [PATCH 3/3] qcow2: reorder fields in Qcow2CachedTable to reduce padding

Changing the current ordering saves 8 bytes per cache entry in x86_64. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz Reviewed-by: Eric Blake --- block/qcow2-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c index a215f5

[Qemu-block] [PATCH 3/3] qcow2: reorder fields in Qcow2CachedTable to reduce padding

Changing the current ordering saves 8 bytes per cache entry in x86_64. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/qcow2-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c index a215f5b..43590ff 100644 --- a/b

Re: [Qemu-block] [PATCH 3/3] qcow2: reorder fields in Qcow2CachedTable to reduce padding

On Tue 26 May 2015 06:10:11 PM CEST, Max Reitz wrote: > On 18.05.2015 18:48, Alberto Garcia wrote: >> Changing the current ordering saves 8 bytes per cache entry in x86_64. > > Hm, not seven? No, the size is 32 before the patch and 24 afterwards. What you save is the 7 bytes of padding after 'dir

Re: [Qemu-block] [PATCH 3/3] qcow2: reorder fields in Qcow2CachedTable to reduce padding

On 26.05.2015 18:12, Eric Blake wrote: On 05/26/2015 10:10 AM, Max Reitz wrote: On 18.05.2015 18:48, Alberto Garcia wrote: Changing the current ordering saves 8 bytes per cache entry in x86_64. Hm, not seven? Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 2 +- 1 file changed,

Re: [Qemu-block] [PATCH 3/3] qcow2: reorder fields in Qcow2CachedTable to reduce padding

On 05/18/2015 10:48 AM, Alberto Garcia wrote: > Changing the current ordering saves 8 bytes per cache entry in x86_64. > > Signed-off-by: Alberto Garcia > --- > block/qcow2-cache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat c

Re: [Qemu-block] [PATCH 3/3] qcow2: reorder fields in Qcow2CachedTable to reduce padding

On 05/26/2015 10:10 AM, Max Reitz wrote: > On 18.05.2015 18:48, Alberto Garcia wrote: >> Changing the current ordering saves 8 bytes per cache entry in x86_64. > > Hm, not seven? > >> Signed-off-by: Alberto Garcia >> --- >> block/qcow2-cache.c | 2 +- >> 1 file changed, 1 insertion(+), 1 dele

Re: [Qemu-block] [PATCH 3/3] qcow2: reorder fields in Qcow2CachedTable to reduce padding

On 18.05.2015 18:48, Alberto Garcia wrote: Changing the current ordering saves 8 bytes per cache entry in x86_64. Hm, not seven? Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2-cache.c b/block/qcow2-cach

[Qemu-block] [PATCH 3/3] qcow2: reorder fields in Qcow2CachedTable to reduce padding

Changing the current ordering saves 8 bytes per cache entry in x86_64. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c index a215f5b..43590ff 100644 --- a/block/qcow2-cache.c +++ b