Re: [Qemu-block] [PATCH 3/4] nbd/server: implement dirty bitmap export

21.03.2018 19:57, Eric Blake wrote: On 03/21/2018 07:19 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy [...] + +#define NBD_STATE_DIRTY 1 Does this belong better in nbd.h, alongside NBD_STATE_HOLE?  (And defining it as

Re: [Qemu-block] [PATCH 3/4] nbd/server: implement dirty bitmap export

21.03.2018 19:57, Eric Blake wrote: On 03/21/2018 07:19 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Rather sparse on the details in the commit message; I had to read the patch to even learn what the new namespace is. oh,

Re: [Qemu-block] [PATCH 3/4] nbd/server: implement dirty bitmap export

On 03/21/2018 07:19 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy Rather sparse on the details in the commit message; I had to read the patch to even learn what the new namespace is. --- include/block/nbd.h | 2 +

[Qemu-block] [PATCH 3/4] nbd/server: implement dirty bitmap export

Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 2 + nbd/server.c| 207 ++-- 2 files changed, 203 insertions(+), 6 deletions(-) diff --git a/include/block/nbd.h b/include/block/nbd.h index