Re: [Qemu-block] [PATCH 4/4] block/nbd-client: use non-blocking io channel for nbd negotiation

2019-02-24 Thread Vladimir Sementsov-Ogievskiy
19.02.2019 16:18, Vladimir Sementsov-Ogievskiy wrote: > 12.02.2019 1:02, Eric Blake wrote: >> On 2/11/19 6:56 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Now negotiation is done in coroutine, so to take benefit of it let's >>> use non-blocking model. >>> >>> Note that QIOChannel handle synchronous

Re: [Qemu-block] [PATCH 4/4] block/nbd-client: use non-blocking io channel for nbd negotiation

2019-02-19 Thread Vladimir Sementsov-Ogievskiy
12.02.2019 1:02, Eric Blake wrote: > On 2/11/19 6:56 AM, Vladimir Sementsov-Ogievskiy wrote: >> Now negotiation is done in coroutine, so to take benefit of it let's >> use non-blocking model. >> >> Note that QIOChannel handle synchronous io calls correctly anyway, so > > s/handle/handles/ > >> it

Re: [Qemu-block] [PATCH 4/4] block/nbd-client: use non-blocking io channel for nbd negotiation

2019-02-11 Thread Eric Blake
On 2/11/19 6:56 AM, Vladimir Sementsov-Ogievskiy wrote: > Now negotiation is done in coroutine, so to take benefit of it let's > use non-blocking model. > > Note that QIOChannel handle synchronous io calls correctly anyway, so s/handle/handles/ > it's not a problem to send final NBD_CMD_DISC to

[Qemu-block] [PATCH 4/4] block/nbd-client: use non-blocking io channel for nbd negotiation

2019-02-11 Thread Vladimir Sementsov-Ogievskiy
Now negotiation is done in coroutine, so to take benefit of it let's use non-blocking model. Note that QIOChannel handle synchronous io calls correctly anyway, so it's not a problem to send final NBD_CMD_DISC to non-blocking channel but using sync qio interface, even not in coroutine. Signed-off-