Re: [Qemu-block] [PATCH 6/9] ide: bdrv_attach_dev() for empty CD-ROM

2017-07-12 Thread Eric Blake
On 07/12/2017 07:57 AM, Kevin Wolf wrote: > If no drive=... option is passed (for an empty drive), we don't only > lack the BlockBackend normally created by parse_drive(), but we also > need to manually call blk_attach_dev(). > > IDE does not support hot unplug, but if it did, qdev would take care

[Qemu-block] [PATCH 6/9] ide: bdrv_attach_dev() for empty CD-ROM

2017-07-12 Thread Kevin Wolf
If no drive=... option is passed (for an empty drive), we don't only lack the BlockBackend normally created by parse_drive(), but we also need to manually call blk_attach_dev(). IDE does not support hot unplug, but if it did, qdev would take care to call the matching blk_detach_dev() on unplug. T