Re: [Qemu-block] [PATCH 8/8] sockets: fix parsing of ipv4/ipv6 opts in parse_socket_addr

2017-08-11 Thread Daniel P. Berrange
On Thu, Aug 10, 2017 at 01:35:15PM -0500, Eric Blake wrote: > On 08/10/2017 11:04 AM, Daniel P. Berrange wrote: > > The inet_parse() function looks for 'ipv4' and 'ipv6' > > flags, but only treats them as bare bool flags. The normal > > QemuOpts parsing would allow on/off values to be set too. > >

Re: [Qemu-block] [PATCH 8/8] sockets: fix parsing of ipv4/ipv6 opts in parse_socket_addr

2017-08-10 Thread Eric Blake
On 08/10/2017 11:04 AM, Daniel P. Berrange wrote: > The inet_parse() function looks for 'ipv4' and 'ipv6' > flags, but only treats them as bare bool flags. The normal > QemuOpts parsing would allow on/off values to be set too. > > This updated inet_parse() so that its handling of the s/updated/up

[Qemu-block] [PATCH 8/8] sockets: fix parsing of ipv4/ipv6 opts in parse_socket_addr

2017-08-10 Thread Daniel P. Berrange
The inet_parse() function looks for 'ipv4' and 'ipv6' flags, but only treats them as bare bool flags. The normal QemuOpts parsing would allow on/off values to be set too. This updated inet_parse() so that its handling of the 'ipv4' and 'ipv6' flags matches that done by QemuOpts. Signed-off-by: Da