Re: [Qemu-block] [PATCH for-2.11] throttle-groups: forget timer and schedule next TGM on detach

2017-11-16 Thread Stefan Hajnoczi
On Thu, Nov 16, 2017 at 11:21:50AM +, Stefan Hajnoczi wrote: > tg->any_timer_armed[] must be cleared when detaching pending timers from > the AioContext. Failure to do so leads to hung I/O because it looks > like there are still timers pending when in fact they have been removed. > > Other Th

Re: [Qemu-block] [PATCH for-2.11] throttle-groups: forget timer and schedule next TGM on detach

2017-11-16 Thread Alberto Garcia
On Thu 16 Nov 2017 12:21:50 PM CET, Stefan Hajnoczi wrote: > tg->any_timer_armed[] must be cleared when detaching pending timers from > the AioContext. Failure to do so leads to hung I/O because it looks > like there are still timers pending when in fact they have been removed. > > Other ThrottleG

[Qemu-block] [PATCH for-2.11] throttle-groups: forget timer and schedule next TGM on detach

2017-11-16 Thread Stefan Hajnoczi
tg->any_timer_armed[] must be cleared when detaching pending timers from the AioContext. Failure to do so leads to hung I/O because it looks like there are still timers pending when in fact they have been removed. Other ThrottleGroupMembers might have requests pending too so it's necessary to sch