Re: [Qemu-block] [PATCH for-2.6] block: Forbid I/O throttling on nodes with multiple parents for 2.6

2016-04-06 Thread Alberto Garcia
On Mon 04 Apr 2016 05:26:02 PM CEST, Kevin Wolf wrote: > As the patches to move I/O throttling to BlockBackend didn't make it in > time for the 2.6 release, but the release adds new ways of configuring > VMs whose behaviour would change once the move is done, we need to > outlaw such

Re: [Qemu-block] [PATCH for-2.6] block: Forbid I/O throttling on nodes with multiple parents for 2.6

2016-04-06 Thread Paolo Bonzini
On 06/04/2016 17:55, Alberto Garcia wrote: >> > [BB] overlay >> > | >> > | >> > [BDS] qcow2 [BB] backing >> > || >> > ++ >> > .| >> > . I/O throttling >>

Re: [Qemu-block] [PATCH for-2.6] block: Forbid I/O throttling on nodes with multiple parents for 2.6

2016-04-06 Thread Alberto Garcia
On Wed 06 Apr 2016 11:59:47 AM CEST, Kevin Wolf wrote: > Let me draw some ASCII art. I'm drawing I/O throttling like a filter > to make the difference clear; in reality it's part of the BDS now or > of the BB in 2.7, so don't let this confuse you. > > Let's assume these command line options: > >

Re: [Qemu-block] [PATCH for-2.6] block: Forbid I/O throttling on nodes with multiple parents for 2.6

2016-04-06 Thread Kevin Wolf
Am 06.04.2016 um 11:45 hat Alberto Garcia geschrieben: > On Mon 04 Apr 2016 05:26:02 PM CEST, Kevin Wolf wrote: > > The problem exists whenever a BDS has more users than just its BB, for > > example it is used as a backing file for another node. > > The code seems correct, but I don't understand

Re: [Qemu-block] [PATCH for-2.6] block: Forbid I/O throttling on nodes with multiple parents for 2.6

2016-04-06 Thread Alberto Garcia
On Mon 04 Apr 2016 05:26:02 PM CEST, Kevin Wolf wrote: > The problem exists whenever a BDS has more users than just its BB, for > example it is used as a backing file for another node. The code seems correct, but I don't understand this use case. Berto

[Qemu-block] [PATCH for-2.6] block: Forbid I/O throttling on nodes with multiple parents for 2.6

2016-04-04 Thread Kevin Wolf
As the patches to move I/O throttling to BlockBackend didn't make it in time for the 2.6 release, but the release adds new ways of configuring VMs whose behaviour would change once the move is done, we need to outlaw such configurations temporarily. The problem exists whenever a BDS has more