Re: [Qemu-block] [PATCH v12 01/31] block: Use bdrv_refresh_filename() to pull

2018-12-22 Thread Alberto Garcia
On Mon 17 Dec 2018 11:43:18 PM CET, Max Reitz wrote: > @@ -3327,6 +,7 @@ static int img_rebase(int argc, char **argv) > qdict_put_bool(options, BDRV_OPT_FORCE_SHARE, true); > } > > +bdrv_refresh_filename(bs); > overlay_filename = bs->exa

[Qemu-block] [PATCH v12 01/31] block: Use bdrv_refresh_filename() to pull

2018-12-17 Thread Max Reitz
Before this patch, bdrv_refresh_filename() is used in a pushing manner: Whenever the BDS graph is modified, the parents of the modified edges are supposed to be updated (recursively upwards). However, that is nonviable, considering that we want child changes not to concern parents. Also, in the l