[Qemu-block] [PATCH v2] hmp: Fix drive_add ... format=help crash

2019-04-08 Thread Markus Armbruster
drive_new() returns null without setting an error when it provided help. add_init_drive() assumes null means failure, and crashes trying to report a null error. Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25 Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster --- v2: Make tests/test-hmp

Re: [Qemu-block] [PATCH v2] hmp: Fix drive_add ... format=help crash

2019-04-08 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > drive_new() returns null without setting an error when it provided > help. add_init_drive() assumes null means failure, and crashes trying > to report a null error. > > Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25 > Cc: qemu-sta...@nongnu.org >

Re: [Qemu-block] [PATCH v2] hmp: Fix drive_add ... format=help crash

2019-04-08 Thread Kevin Wolf
Am 08.04.2019 um 17:30 hat Markus Armbruster geschrieben: > drive_new() returns null without setting an error when it provided > help. add_init_drive() assumes null means failure, and crashes trying > to report a null error. > > Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25 > Cc: qemu-sta...@no