Re: [Qemu-block] [PATCH v2 02/17] crypto: add cryptographic random byte source

2016-02-04 Thread Eric Blake
On 01/20/2016 10:38 AM, Daniel P. Berrange wrote: > There are three backend impls provided. The preferred > is gnutls, which is backed by nettle in modern distros. > The gcrypt impl is provided for cases where QEMU build > against gnutls is disabled, but crypto is still desired. > No nettle impl is

Re: [Qemu-block] [PATCH v2 02/17] crypto: add cryptographic random byte source

2016-01-21 Thread Daniel P. Berrange
On Thu, Jan 21, 2016 at 02:12:06PM +0800, Fam Zheng wrote: > On Wed, 01/20 17:38, Daniel P. Berrange wrote: > > +int qcrypto_random_bytes(uint8_t *buf G_GNUC_UNUSED, > > + size_t buflen G_GNUC_UNUSED, > > + Error **errp) > > +{ > > +error_setg(err

Re: [Qemu-block] [PATCH v2 02/17] crypto: add cryptographic random byte source

2016-01-20 Thread Fam Zheng
On Wed, 01/20 17:38, Daniel P. Berrange wrote: > +int qcrypto_random_bytes(uint8_t *buf G_GNUC_UNUSED, > + size_t buflen G_GNUC_UNUSED, > + Error **errp) > +{ > +error_setg(errp, "No random byte source provided in this build"); > +return -1;

[Qemu-block] [PATCH v2 02/17] crypto: add cryptographic random byte source

2016-01-20 Thread Daniel P. Berrange
There are three backend impls provided. The preferred is gnutls, which is backed by nettle in modern distros. The gcrypt impl is provided for cases where QEMU build against gnutls is disabled, but crypto is still desired. No nettle impl is provided, since it is non-trivial to use the nettle APIs fo