Re: [Qemu-block] [PATCH v2 1/1] include: Add a comment to explain the origin of sizes' lookup table

2018-11-06 Thread Kevin Wolf
Am 06.11.2018 um 09:56 hat Leonid Bloch geschrieben: > Hi Phil, Hi Eric, > > (Eric, for some reason you weren't CC'd to this thread - sorry.) > > On 11/5/18 5:58 PM, Philippe Mathieu-Daudé wrote: > > Hi Leonid, > > > > On 4/11/18 19:07, Leonid Bloch wrote: > >> The lookup table for power-of-two

Re: [Qemu-block] [PATCH v2 1/1] include: Add a comment to explain the origin of sizes' lookup table

2018-11-06 Thread Leonid Bloch
Hi Phil, Hi Eric, (Eric, for some reason you weren't CC'd to this thread - sorry.) On 11/5/18 5:58 PM, Philippe Mathieu-Daudé wrote: > Hi Leonid, > > On 4/11/18 19:07, Leonid Bloch wrote: >> The lookup table for power-of-two sizes was added in commit 540b8492618eb >> for the purpose of having co

Re: [Qemu-block] [PATCH v2 1/1] include: Add a comment to explain the origin of sizes' lookup table

2018-11-05 Thread Philippe Mathieu-Daudé
Hi Leonid, On 4/11/18 19:07, Leonid Bloch wrote: The lookup table for power-of-two sizes was added in commit 540b8492618eb for the purpose of having convenient shortcuts for these sizes in cases when the literal number has to be present at compile time, and expressions as '(1 * KiB)' can not be

[Qemu-block] [PATCH v2 1/1] include: Add a comment to explain the origin of sizes' lookup table

2018-11-04 Thread Leonid Bloch
The lookup table for power-of-two sizes was added in commit 540b8492618eb for the purpose of having convenient shortcuts for these sizes in cases when the literal number has to be present at compile time, and expressions as '(1 * KiB)' can not be used. One such case is the stringification of sizes.