Re: [Qemu-block] [PATCH v2 1/2] make: move generated headers to qemu-build/

2018-03-23 Thread Michael S. Tsirkin
On Fri, Mar 23, 2018 at 10:22:27AM +, Daniel P. Berrangé wrote: > On Thu, Mar 22, 2018 at 09:27:55PM +0200, Michael S. Tsirkin wrote: > > Make sure all generated files go into qemu-build subdirectory. > > We can then include them like this: > > #include "qemu-build/trace.h" > > > > This

Re: [Qemu-block] [PATCH v2 1/2] make: move generated headers to qemu-build/

2018-03-23 Thread Daniel P . Berrangé
On Thu, Mar 22, 2018 at 09:27:55PM +0200, Michael S. Tsirkin wrote: > Make sure all generated files go into qemu-build subdirectory. > We can then include them like this: > #include "qemu-build/trace.h" > > This serves two purposes: > - make it easy to detect which files are in the source >

Re: [Qemu-block] [PATCH v2 1/2] make: move generated headers to qemu-build/

2018-03-22 Thread Michael S. Tsirkin
On Thu, Mar 22, 2018 at 02:42:55PM -0500, Eric Blake wrote: > On 03/22/2018 02:27 PM, Michael S. Tsirkin wrote: > > Make sure all generated files go into qemu-build subdirectory. > > We can then include them like this: > > #include "qemu-build/trace.h" > > > > This serves two purposes: > > -

Re: [Qemu-block] [PATCH v2 1/2] make: move generated headers to qemu-build/

2018-03-22 Thread Eric Blake
On 03/22/2018 02:27 PM, Michael S. Tsirkin wrote: Make sure all generated files go into qemu-build subdirectory. We can then include them like this: #include "qemu-build/trace.h" This serves two purposes: - make it easy to detect which files are in the source directory (a bit more work for

[Qemu-block] [PATCH v2 1/2] make: move generated headers to qemu-build/

2018-03-22 Thread Michael S. Tsirkin
Make sure all generated files go into qemu-build subdirectory. We can then include them like this: #include "qemu-build/trace.h" This serves two purposes: - make it easy to detect which files are in the source directory (a bit more work for writers, easier for readers) - reduce chances of