Re: [Qemu-block] [PATCH v2 2/3] block/mirror: Fix target backing BDS

2016-06-09 Thread Nir Soffer
On Thu, Jun 9, 2016 at 11:58 AM, Kevin Wolf wrote: > Am 08.06.2016 um 17:39 hat Nir Soffer geschrieben: >> On Wed, Jun 8, 2016 at 12:32 PM, Kevin Wolf wrote: >> > Am 06.06.2016 um 16:42 hat Max Reitz geschrieben: >> >> Currently, we are trying to move the backing BDS from the source to the >> >>

Re: [Qemu-block] [PATCH v2 2/3] block/mirror: Fix target backing BDS

2016-06-09 Thread Kevin Wolf
Am 08.06.2016 um 17:39 hat Nir Soffer geschrieben: > On Wed, Jun 8, 2016 at 12:32 PM, Kevin Wolf wrote: > > Am 06.06.2016 um 16:42 hat Max Reitz geschrieben: > >> Currently, we are trying to move the backing BDS from the source to the > >> target in bdrv_replace_in_backing_chain() which is called

Re: [Qemu-block] [PATCH v2 2/3] block/mirror: Fix target backing BDS

2016-06-08 Thread Nir Soffer
On Wed, Jun 8, 2016 at 12:32 PM, Kevin Wolf wrote: > Am 06.06.2016 um 16:42 hat Max Reitz geschrieben: >> Currently, we are trying to move the backing BDS from the source to the >> target in bdrv_replace_in_backing_chain() which is called from >> mirror_exit(). However, mirror_complete() already t

Re: [Qemu-block] [PATCH v2 2/3] block/mirror: Fix target backing BDS

2016-06-08 Thread Max Reitz
On 08.06.2016 16:38, Max Reitz wrote: > On 08.06.2016 11:32, Kevin Wolf wrote: >> Am 06.06.2016 um 16:42 hat Max Reitz geschrieben: >>> Currently, we are trying to move the backing BDS from the source to the >>> target in bdrv_replace_in_backing_chain() which is called from >>> mirror_exit(). Howev

Re: [Qemu-block] [PATCH v2 2/3] block/mirror: Fix target backing BDS

2016-06-08 Thread Max Reitz
On 08.06.2016 13:28, Paolo Bonzini wrote: > > > - Original Message - >> From: "Kevin Wolf" >> To: "Max Reitz" >> Cc: qemu-block@nongnu.org, qemu-de...@nongnu.org, "Fam Zheng" >> , nsof...@redhat.com, >> ebl...@redhat.com, pbonz...@redhat.com >> Sent: Wednesday, June 8, 2016 11:32:29 AM

Re: [Qemu-block] [PATCH v2 2/3] block/mirror: Fix target backing BDS

2016-06-08 Thread Max Reitz
On 08.06.2016 11:32, Kevin Wolf wrote: > Am 06.06.2016 um 16:42 hat Max Reitz geschrieben: >> Currently, we are trying to move the backing BDS from the source to the >> target in bdrv_replace_in_backing_chain() which is called from >> mirror_exit(). However, mirror_complete() already tries to open

Re: [Qemu-block] [PATCH v2 2/3] block/mirror: Fix target backing BDS

2016-06-08 Thread Max Reitz
On 08.06.2016 16:40, Max Reitz wrote: > On 08.06.2016 13:28, Paolo Bonzini wrote: >> >> >> - Original Message - >>> From: "Kevin Wolf" >>> To: "Max Reitz" >>> Cc: qemu-block@nongnu.org, qemu-de...@nongnu.org, "Fam Zheng" >>> , nsof...@redhat.com, >>> ebl...@redhat.com, pbonz...@redhat.co

Re: [Qemu-block] [PATCH v2 2/3] block/mirror: Fix target backing BDS

2016-06-08 Thread Kevin Wolf
Am 08.06.2016 um 13:28 hat Paolo Bonzini geschrieben: > > > - Original Message - > > From: "Kevin Wolf" > > To: "Max Reitz" > > Cc: qemu-block@nongnu.org, qemu-de...@nongnu.org, "Fam Zheng" > > , nsof...@redhat.com, > > ebl...@redhat.com, pbonz...@redhat.com > > Sent: Wednesday, June 8

Re: [Qemu-block] [PATCH v2 2/3] block/mirror: Fix target backing BDS

2016-06-08 Thread Paolo Bonzini
- Original Message - > From: "Kevin Wolf" > To: "Max Reitz" > Cc: qemu-block@nongnu.org, qemu-de...@nongnu.org, "Fam Zheng" > , nsof...@redhat.com, > ebl...@redhat.com, pbonz...@redhat.com > Sent: Wednesday, June 8, 2016 11:32:29 AM > Subject: Re: [PATCH v2 2/3] block/mirror: Fix targe

Re: [Qemu-block] [PATCH v2 2/3] block/mirror: Fix target backing BDS

2016-06-08 Thread Kevin Wolf
Am 06.06.2016 um 16:42 hat Max Reitz geschrieben: > Currently, we are trying to move the backing BDS from the source to the > target in bdrv_replace_in_backing_chain() which is called from > mirror_exit(). However, mirror_complete() already tries to open the > target's backing chain with a call to

[Qemu-block] [PATCH v2 2/3] block/mirror: Fix target backing BDS

2016-06-06 Thread Max Reitz
Currently, we are trying to move the backing BDS from the source to the target in bdrv_replace_in_backing_chain() which is called from mirror_exit(). However, mirror_complete() already tries to open the target's backing chain with a call to bdrv_open_backing_file(). First, we should only set the t