Re: [Qemu-block] [PATCH v2 2/3] block/parallals: Do not update header or truncate image when INMIGRATE

2017-11-06 Thread Jeff Cody
On Mon, Nov 06, 2017 at 03:23:43PM -0500, Jeff Cody wrote: > On Fri, Nov 03, 2017 at 02:08:13PM +0300, Denis V. Lunev wrote: > > On 11/03/2017 02:05 PM, Stefan Hajnoczi wrote: > > > On Mon, Oct 30, 2017 at 02:10:27PM +0100, Jeff Cody wrote: > > >> If we write or modify the image file while the QEMU

Re: [Qemu-block] [PATCH v2 2/3] block/parallals: Do not update header or truncate image when INMIGRATE

2017-11-06 Thread Jeff Cody
On Fri, Nov 03, 2017 at 02:08:13PM +0300, Denis V. Lunev wrote: > On 11/03/2017 02:05 PM, Stefan Hajnoczi wrote: > > On Mon, Oct 30, 2017 at 02:10:27PM +0100, Jeff Cody wrote: > >> If we write or modify the image file while the QEMU run state is > >> INMIGRATE, then the BDRV_O_INACTIVE BDS flag is

Re: [Qemu-block] [PATCH v2 2/3] block/parallals: Do not update header or truncate image when INMIGRATE

2017-11-03 Thread Denis V. Lunev
On 11/03/2017 02:05 PM, Stefan Hajnoczi wrote: > On Mon, Oct 30, 2017 at 02:10:27PM +0100, Jeff Cody wrote: >> If we write or modify the image file while the QEMU run state is >> INMIGRATE, then the BDRV_O_INACTIVE BDS flag is set. This will cause >> an assert, since the image is marked inactive.

Re: [Qemu-block] [PATCH v2 2/3] block/parallals: Do not update header or truncate image when INMIGRATE

2017-11-03 Thread Stefan Hajnoczi
On Mon, Oct 30, 2017 at 02:10:27PM +0100, Jeff Cody wrote: > If we write or modify the image file while the QEMU run state is > INMIGRATE, then the BDRV_O_INACTIVE BDS flag is set. This will cause > an assert, since the image is marked inactive. Make sure we obey this > flag. > > Signed-off-by:

[Qemu-block] [PATCH v2 2/3] block/parallals: Do not update header or truncate image when INMIGRATE

2017-10-30 Thread Jeff Cody
If we write or modify the image file while the QEMU run state is INMIGRATE, then the BDRV_O_INACTIVE BDS flag is set. This will cause an assert, since the image is marked inactive. Make sure we obey this flag. Signed-off-by: Jeff Cody --- block/parallels.c | 7 ++- 1 file changed, 2 insert